Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] PHPDoc errors #11699

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[Fix] PHPDoc errors #11699

merged 2 commits into from
Oct 3, 2024
+105 −983

Conversation

esizer
Copy link
Member

@esizer esizer commented Oct 3, 2024

🤖 Resolves #11598

👋 Introduction

Fixes errors with our PHPDocs.

🕵️ Details

Thios mostly removes them to rely on native type hinting more.

🧪 Testing

  1. Confirm no longer ignoring any PHPDoc errors
  2. Confirm linting passes
  3. Confirm type hints make sense

@vd1992 vd1992 self-requested a review October 3, 2024 18:56
vd1992
vd1992 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all fine

@esizer esizer added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 0b59991 Oct 3, 2024
7 checks passed
@esizer esizer deleted the 11598-fix-phpdoc-errors branch October 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vd1992 vd1992 vd1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Larastan: PHPDoc tag errors
2 participants
@esizer @vd1992