Fix UCSC trackhub assembly aliases matching #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount to make authorization work for Trix index files.
…SC Track hub connection.
github-actions
bot
added
the
needs label triage
|
can merge as is, may update on main branch a little to use the 'hasName' or 'allAliases.includes' type cleanups and add a integration test |
cmdcolin
added
bug
cmdcolin
changed the title
cmdcolin
pushed a commit
that referenced
this pull request
May 18, 2023
* Add aliases matching to existing name matching for assemblies from UCSC Track hub connection. --------- Co-authored-by: grzelaka <andrzej.grzelak@contractors.roche.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you try to add UCSC connection and your assemblies name doesn't match the assembly names used in UCSC trackhub configuration exactly they won't load even if you add proper aliases to them.
This change fixes that by looking into aliases for matching assemblies.