Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renderDelay not being applied to dynamicBlocks #3637

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 11, 2023

This is a more minimal PR to address same issue as #3595

That PR tried to introduce many refactorings to the block based system including how we hydrate content from our web worker, but I ran into many odd errors with this.

This PR just adds a delay before creating the makeAbortableReaction on the serverSideRenderedBlock afterAttach

Fixes #887

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 11, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3637 (e1d4ced) into main (193fbec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
+ Coverage   63.06%   63.08%   +0.01%     
==========================================
  Files         871      871              
  Lines       30189    30190       +1     
  Branches     7269     7269              
==========================================
+ Hits        19039    19044       +5     
+ Misses      10965    10961       -4     
  Partials      185      185              
Impacted Files Coverage Δ
...aseLinearDisplay/models/serverSideRenderedBlock.ts 95.27% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 3a5ee14 into main Apr 12, 2023
@cmdcolin cmdcolin deleted the dynamic_blocks_renderdelay2 branch April 12, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic blocks renderDelay
1 participant