Fix error handling of feature detail formatter jexl callbacks #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
cmdcolin
force-pushed
the
error_catch_basefeaturedetail
branch
from
299661b
to
cdf350f
Compare
cmdcolin
force-pushed
the
error_catch_basefeaturedetail
branch
from
cdf350f
to
229d0ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
- Coverage 63.08% 63.08% -0.01%
==========================================
Files 876 876
Lines 30173 30182 +9
Branches 7276 7278 +2
==========================================
+ Hits 19035 19039 +4
- Misses 10953 10958 +5
Partials 185 185
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This discussion (#3640) showed me that the feature detail panel can present with a blank panel if an error occurs in a user's jexl callbacks for example. This PR adds a try/catch that now presents the user with an error if the jexl callback fails