Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-popper for tooltips in DotplotView #3675

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 1, 2023

This updates the dotplot view tooltips to use react-popper instead of an absolute-positioned div with text

The absolute-positioned div can run into text-formatting issues near the margins, but the popper tries to lay out the text more nicely

Comparison

after

Screenshot from 2023-05-01 13-07-18

before

Screenshot from 2023-05-01 13-05-46

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #3675 (1bb386d) into main (f75837d) will decrease coverage by 0.01%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##             main    #3675      +/-   ##
==========================================
- Coverage   62.64%   62.63%   -0.01%     
==========================================
  Files         892      892              
  Lines       30235    30252      +17     
  Branches     7319     7321       +2     
==========================================
+ Hits        18940    18948       +8     
- Misses      11112    11121       +9     
  Partials      183      183              
Impacted Files Coverage Δ
...view/src/DotplotView/components/DotplotTooltip.tsx 38.63% <29.16%> (-4.23%) ⬇️
...ot-view/src/DotplotView/components/DotplotView.tsx 50.75% <100.00%> (+0.37%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 1, 2023
@cmdcolin cmdcolin merged commit ba81be7 into main May 3, 2023
@cmdcolin cmdcolin deleted the portal_dotplot_view branch May 3, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant