implement improved camel case #630
Conversation
There was a problem hiding this comment.
The code crashes on me when checking any camel case word:
Starting program: /home/kevina/devel/aspell/inst/bin/aspell -a --camel-case
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.9-git)
theBuild
Program received signal SIGSEGV, Segmentation fault.
0x000055555556733e in status_fun (d=0x7fffffffd710, correct=1) at ../prog/aspell.cpp:677
677 if (ci->compound)
(gdb) bt
#0 0x000055555556733e in status_fun (d=0x7fffffffd710, correct=1) at ../prog/aspell.cpp:677
#1 0x00005555555af66b in acommon::DocumentChecker::next_misspelling (this=0x5555556d2d90) at ../common/document_checker.cpp:86
#2 0x00005555555686b7 in pipe () at ../prog/aspell.cpp:867
#3 0x0000555555565cdb in main (argc=3, argv=0x7fffffffe158) at ../prog/aspell.cpp:419
(gdb) p ci
$1 = (const acommon::CheckInfo *) 0x0
|
Please let me know when this is ready for me to look at it again by using the re-request review feature. It will likely be sometime early January before I am able to look at. |
|
aPipeCheckNowWorksEvenOnCamelCaseStringsHavingNUMEROUSComponents build_jessie fails even if there are no code changes. Apologies for extraneous commits, but I have had trouble getting all the automated checks to run in Cygwin. |
test/sanity
Outdated
| @@ -32,3 +32,20 @@ else | |||
| exit 1 | |||
| fi | |||
|
|
|||
| echo 'itIsOKForACamelCaseWordToContainNumerousCOMPONENTS' | aspell --camel-case -d en_US -a > tmp/res | |||
| if cat tmp/res | fgrep '-'; then | |||
There was a problem hiding this comment.
Sanity is meant for a few quick tests to make sure Aspell functions at all. Specific unit tests should be in a separate file. Please move these into the file test/camel_case and add a target for it in the Makefile.
Addresses #629