Added: explicitly setting false value for testing disabled feature flags

GPortas · Mar 24, 2023 · e427b82 · e427b82
1 parent 3cb0ae0
commit e427b82
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java b/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java
@@ -23,6 +23,7 @@ public void setUp() {
     }
 
     @Test
+    @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "false", varArgs = "api-session-auth")
     public void testFindUserFromRequest_FeatureFlagDisabled() throws WrappedAuthErrorResponse {
         sut.session = Mockito.mock(DataverseSession.class);
 

diff --git a/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java b/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java
@@ -8,12 +8,13 @@
 class FeatureFlagsTest {
 
     @Test
+    @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "false", varArgs = "api-session-auth")
     void testFlagDisabled() {
         assertFalse(FeatureFlags.API_SESSION_AUTH.enabled());
     }
 
     @Test
-    @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "on", varArgs = "api-session-auth")
+    @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "true", varArgs = "api-session-auth")
     void testFlagEnabled() {
         assertTrue(FeatureFlags.API_SESSION_AUTH.enabled());
     }