-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around renamed ENUM_P_TYPE variables in elftools 0.25 and up. #1191
Conversation
b66c23c
to
489393a
Compare
Added a comment, thanks! |
@zachriggle (who commented on PR #1190) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍
While this allows pwntools to run for me, I couldn't successfully execute the demo code in http://docs.pwntools.com/en/stable/elf/corefile.html?highlight=core#using-corefiles-to-automate-exploitation. With this patch:
And with pyelftools pinned to 0.24
The assertion is bad...but at least now pwntools can read the core file. |
Fixed with |
Elftools 0.25 renamed ENUM_P_TYPE to ENUM_P_TYPE_BASE: eliben/pyelftools@7371660
Work around this by attempting to import both names.
Fixes #1189.