Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process] Add writemem with tests, alias readmem == leak #1652

Merged
merged 10 commits into from
Apr 29, 2021

Conversation

heapcrash
Copy link
Collaborator

Closes #1648

@heapcrash
Copy link
Collaborator Author

I've got no idea why this isn't working. It works locally, and it's generating exactly the same assembly as I'm using locally.

@Arusekk any ideas?

@heapcrash
Copy link
Collaborator Author

It even works on REPL.it when you stub in the code from writemem() since it's not available yet on stable:
https://repl.it/join/xbahrfxr-heapcrash

@heapcrash
Copy link
Collaborator Author

I would assume that YAMA is doing something here, but we disable it in ci.yml:

        echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope # required by some gdb doctests
        PWNLIB_NOTERM=1 coverage run -m sphinx -b doctest docs/source docs/build/doctest

pwnlib/tubes/process.py Outdated Show resolved Hide resolved
@zachriggle
Copy link
Member

Should we just merge this and remove / neuter the tests by making them code blocks instead of doctests?

@Arusekk Arusekk merged commit 797c3ee into Gallopsled:dev Apr 29, 2021
@heapcrash heapcrash deleted the process-writemem branch May 31, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Write Memory from /proc/pic/mem, add more tooling around that
3 participants