Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Python3 for the remotely-executed Python script #1746

Merged

Conversation

heapcrash
Copy link
Collaborator

This should be done as part of our general transition to Python3,
but should also be done because some systems with e.g. Python2.6
do not support OrderedDict, but DO have a Python3 version that works.

@heapcrash heapcrash force-pushed the prefer-python3-for-ssh-remote-script branch from 02109e2 to b2940b3 Compare December 18, 2020 19:52
This should be done as part of our general transition to Python3,
but should also be done because some systems with e.g. Python2.6
do not support OrderedDict, but DO have a Python3 version that works.
@heapcrash heapcrash force-pushed the prefer-python3-for-ssh-remote-script branch from b2940b3 to 631096d Compare December 18, 2020 19:53
Copy link
Member

@Arusekk Arusekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that prepending python3 would be just enough.

pwnlib/tubes/ssh.py Outdated Show resolved Hide resolved
pwnlib/tubes/ssh.py Outdated Show resolved Hide resolved
@Arusekk Arusekk linked an issue Apr 28, 2021 that may be closed by this pull request
This actually is a behavior change, and can be a breaking change for some,
so must be stated prominently in the changelog.
@Arusekk Arusekk merged commit cb24f37 into Gallopsled:dev Apr 28, 2021
@Arusekk Arusekk linked an issue Apr 28, 2021 that may be closed by this pull request
@heapcrash heapcrash deleted the prefer-python3-for-ssh-remote-script branch May 31, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh.py use python3 ssh python script support python3
2 participants