Cleanup unconditional imports #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may aid Gallopsled#1725
zachriggle
reviewed
Dec 30, 2020
zachriggle
reviewed
Dec 30, 2020
| @@ -1,19 +1,5 @@ | |||
| from __future__ import absolute_import | |||
|
|
|||
| from pwnlib.util import crc | |||
There was a problem hiding this comment.
It seems that this will break import pwnlib.util and then doing e.g. pwnlib.util.cyclic.xyz, no?
There was a problem hiding this comment.
Yes, it will. But!
But this removal saves us partially from the hell of circular imports. Like when pwnlib.xyz uses pwnlib.util.misc, but pwnlib.util.fiddling uses pwnlib.xyz, this is not a circular import normally, but all those imports here make it such if from . import fiddling is before from . import misc. And this sometimes depends on the order of imports elsewhere. So I decided that we can sacrifice convenience in favor of flexibility here.
zachriggle
reviewed
Dec 30, 2020
pwnlib/gdb.py
Outdated
| @@ -1009,6 +1006,9 @@ def preexec_fn(): | |||
|
|
|||
| if api: | |||
| # connect to the GDB Python API bridge | |||
| from rpyc import BgServingThread | |||
XXX: see why this matters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may aid #1725