Changed util.fiddling.hexdump_iter to take a file object instead of…
#695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a string. This massively speeds up `phd <file> | less` for huge files.
|
I think that @idolf doesn't want any extra branches. In the future, create the PR from a fork. For the purpose of back-ports, does this have any functional changes? Or can it just be rolled into the "next release"? |
|
Since this is against |
|
@zachriggle, OK, I'll do PR's from a fork in the future. Thanks for merging. |
|
I am backporting this to stable now, as this is a regression fix. |
TethysSvensson
pushed a commit
to TethysSvensson/pwntools
that referenced
this pull request
Sep 6, 2016
… a string. This massively speeds up `phd <file> | less` for huge files. (Gallopsled#695)
Merged
|
This was cherry-picked to 3.0.2 so realistically that's the milestone |
zachriggle
added a commit
to zachriggle/pwntools
that referenced
this pull request
Jan 10, 2017
This code wasnt updated when the code was changed to operate on file descriptors. Additionally, there was a functional regression, that the first line would be skipped. Fixes: Gallopsled#836 Caused by: Gallopsled#695 (d65991d)
Kyle-Kyle
pushed a commit
to Kyle-Kyle/pwntools
that referenced
this pull request
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a string. This massively speeds up
phd <file> | lessfor huge files.