Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more adb commands. #703

Closed
wants to merge 1 commit into from
Closed

Add more adb commands. #703

wants to merge 1 commit into from

Conversation

gregthedoe
Copy link

  1. Create a simple function to run adb shell command.
  2. Add install and uninstall of android packages.

1. Create a simple function to run adb shell command.
2. Add install and uninstall of android packages.
@TethysSvensson
Copy link
Contributor

I think this looks reasonable, but I have not looked at the adb code before. @zachriggle, what do you think?

@gregthedoe: Could you add a note to the changelog about this as well?

@zachriggle: This decreases coverage, as the adb is untested. Is there any way for us to test this code?

@zachriggle
Copy link
Member

I was working last night on getting some stuff to test via an emulator on
Travis, but got hung up because my DO VPS doesn't have the disk space or
RAM required to run one.
On Fri, Aug 26, 2016 at 1:11 PM Mathias Svensson notifications@github.com
wrote:

I think this looks reasonable, but I have not looked at the adb code
before. @zachriggle https://github.com/zachriggle, what do you think?

@gregthedoe https://github.com/gregthedoe: Could you add a note to the
changelog about this as well?

@zachriggle https://github.com/zachriggle: This decreases coverage, as
the adb is untested. Is there any way for us to test this code?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#703 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG0GGK7PdV40Fsp_wJO6EJfhF-bZSOBks5qj0h0gaJpZM4Js404
.

@zachriggle
Copy link
Member

Since #709 landed, this will need to be rewritten.
Since #705 landed, we have doctests which use an Android 5.0 Lollipop emulator image

@zachriggle
Copy link
Member

This is obsolete as of 4893819

@zachriggle zachriggle closed this Sep 28, 2016
@zachriggle zachriggle modified the milestones: Someday, 3.2.0 Sep 28, 2016
@zachriggle zachriggle self-assigned this Sep 28, 2016
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants