Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle exceptions in remote._connect. #793

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

rickyz
Copy link
Contributor

@rickyz rickyz commented Nov 20, 2016

Previously, if getaddrinfo or socket.socket threw an exception,
_connect would return without ever calling h.success or h.failure. As a
result, progress indicators would continue to update indefinitely.

Fix this by using a with statement instead.

(Also remove an unused variable and fix a typo.)

Previously, if getaddrinfo or socket.socket threw an exception,
_connect would return without ever calling h.success or h.failure. As a
result, progress indicators would continue to update indefinitely.

Fix this by using a with statement instead.

(Also remove an unused variable and fix a typo.)
@zachriggle
Copy link
Member

It looks like the coverage that Coveralls is complaining about is only due to the fact that Android tests are only run when Android-related changes are made.

This looks like a good merge otherwise.

@idolf, since this needs to be merged to stable, would you mind? ^_^

@zachriggle zachriggle added the bug label Nov 23, 2016
@zachriggle zachriggle added this to the 3.2.0 milestone Nov 23, 2016
@zachriggle
Copy link
Member

zachriggle commented Nov 23, 2016

@rickyz is there any way to add a test for this bit of functionality, to prevent future regressions?

@TethysSvensson
Copy link
Contributor

@zachriggle: LGTM. Please merge once you are satisfied with the test situation and ping me to do a new release.

@zachriggle
Copy link
Member

The change is very small when viewed with white-space changes ignored, it basically turns w = log.waitfor to with log.waitfor as w.

@zachriggle zachriggle merged commit 2f597f4 into Gallopsled:stable Nov 28, 2016
@zachriggle
Copy link
Member

@idolf ping ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants