Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all imports to absolute per PEP-328, and sort imports #832

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Change all imports to absolute per PEP-328, and sort imports #832

merged 1 commit into from
Jan 3, 2017

Conversation

zachriggle
Copy link
Member

@zachriggle zachriggle commented Jan 3, 2017 •
edited
Loading

A lot of the motivation for this is to make the code more similar to Pwndbg's style, as well as closer to Google's internal style.

This also paves the way for Python3 support.

@zachriggle zachriggle added this to the Someday milestone Jan 3, 2017
@zachriggle zachriggle self-assigned this Jan 3, 2017
TethysSvensson
TethysSvensson approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@TethysSvensson TethysSvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachriggle zachriggle merged commit 1d59a90 into Gallopsled:dev Jan 3, 2017
@zachriggle zachriggle deleted the pep-328 branch January 4, 2017 18:00
@TethysSvensson TethysSvensson modified the milestones: 3.5.0, Someday Jan 10, 2017
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this pull request Apr 25, 2021
@Things-Z
Fixed bug: bins gets the wrong pointer offset (Gallopsled#832)
7690b60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TethysSvensson TethysSvensson TethysSvensson approved these changes

Assignees

@zachriggle zachriggle

Labels
enhancement
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zachriggle @TethysSvensson