Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-level DB lock in get_annotator_task to avoid race condition #375

Merged
merged 1 commit into from
May 22, 2023
Merged

User-level DB lock in get_annotator_task to avoid race condition #375

merged 1 commit into from
May 22, 2023

Conversation

ianroberts
Copy link
Member

Fixes #374

@ianroberts
Acquire a row lock on the user before checking for an annotation task…
89d0cd5 
…, since otherwise concurrent calls can cause a race condition and assign two different documents to the same user at the same time, causing errors later.

Fixes #374
@ianroberts ianroberts requested a review from twinkarma May 16, 2023 18:13
@github-actions
Copy link

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 86.66 85.45 53.33 86.66
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 86.66 85.45 53.33 86.66
_jrpc 94.04 91.66 83.33 94.04
_ index.js 94.04 91.66 83.33 94.04 29-30,38-40
_utils 83.98 83.72 33.33 83.98
_ annotations.js 97.72 73.91 100 97.72 35-36
_ dict.js 88.88 83.33 100 88.88 3-4
_ index.js 73.6 100 14.28 73.6 9-17,28-29,43-53,64-65,76-82,93-94

@twinkarma twinkarma merged commit c78be97 into dev May 22, 2023
@ianroberts ianroberts deleted the issue-374 branch May 25, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twinkarma twinkarma Awaiting requested review from twinkarma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianroberts @twinkarma