-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4543] & [4529] - Add a channel avatar handler to MessageListHeader
and update docs
#4545
Merged
filbabic
merged 7 commits into
develop
from
improvement/4543-add-message-list-header-channel-avatar-listener
Dec 7, 2022
Merged
[4543] & [4529] - Add a channel avatar handler to MessageListHeader
and update docs
#4545
filbabic
merged 7 commits into
develop
from
improvement/4543-add-message-list-header-channel-avatar-listener
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinTolic
commented
Nov 29, 2022
...oid-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/compose/messages/MessageListHeader.kt
Show resolved
Hide resolved
15 tasks
skydoves
added
the
docs
Either a doc problem or a question that can be avoided by improving our documentation
label
Nov 29, 2022
skydoves
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me!
...oid-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/compose/messages/MessageListHeader.kt
Show resolved
Hide resolved
This reverts commit 890b160.
Closed
…channel-avatar-listener
filbabic
reviewed
Dec 7, 2022
docusaurus/docs/Android/04-compose/05-message-components/02-message-list-header.mdx
Outdated
Show resolved
Hide resolved
…ssage-list-header.mdx
filbabic
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️Reviewer Checklist
- UI Components sample runs & works
- Compose sample runs & works
- UI Changes correct (before & after images)
- Bugs validated (bugfixes)
- New feature tested and works
- Release notes and docs clearly describe changes
- All code we touched has new or updated KDocs
filbabic
deleted the
improvement/4543-add-message-list-header-channel-avatar-listener
branch
December 7, 2022 08:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
closes #4543
closes #4529
🛠 Implementation details
MessageListHeader
🧪 Testing
Patch that implements the new handler
Expected: Should show toast
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF