fix: avoid querying threads with 0 limit (#1361)

GetStream · Sep 11, 2024 · 1393bac · 1393bac
1 parent 34bc8d7
commit 1393bac
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/thread_manager.ts b/src/thread_manager.ts
@@ -208,7 +208,9 @@ export class ThreadManager<SCG extends ExtendableGenerics = DefaultGenerics> {
         },
       }));
 
-      const response = await this.queryThreads({ limit: Math.min(limit, MAX_QUERY_THREADS_LIMIT) });
+      const response = await this.queryThreads({
+        limit: Math.min(limit, MAX_QUERY_THREADS_LIMIT) || MAX_QUERY_THREADS_LIMIT,
+      });
 
       const currentThreads = this.threadsById;
       const nextThreads: Thread<SCG>[] = [];

diff --git a/test/unit/threads.test.ts b/test/unit/threads.test.ts
@@ -1099,6 +1099,14 @@ describe('Threads 2.0', () => {
       });
 
       describe('reload', () => {
+        it('reloads with a default limit if both threads and unseenThreadIds are empty', async () => {
+          threadManager.state.partialNext({
+            threads: [],
+            unseenThreadIds: [],
+          });
+          await threadManager.reload();
+          expect(stubbedQueryThreads.calledWithMatch({ limit: 25 })).to.be.true;
+        });
         it('skips reload if there were no updates since the latest reload', async () => {
           threadManager.state.partialNext({ ready: true });
           await threadManager.reload();