fix: evaluate channel.lastRead when channel is not initialized #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz and
arnautov-anton
as code owners
|
Size Change: -13 B (0%) Total Size: 320 kB
|
oliverlaz
reviewed
Oct 5, 2023
oliverlaz
previously approved these changes
Oct 6, 2023
…r uninitialized channel" This reverts commit 5250973.
oliverlaz
previously approved these changes
Oct 6, 2023
oliverlaz
approved these changes
Oct 6, 2023
vishalnarkhede
approved these changes
Oct 6, 2023
MartinCupela
deleted the
fix/channel-lastRead-for-uninitialized-channel
branch
Merged
rchl
added a commit
to rchl/stream-chat-js
that referenced
this pull request
Nov 29, 2023
* master: (44 commits) chore: release v8.14.4 (GetStream#1203) fix: add default contentType as multipart/form-data in sendFile (GetStream#1202) chore: release v8.14.3 (GetStream#1200) fix: use postForm instead of post for sending files (GetStream#1199) chore: release v8.14.2 (GetStream#1197) fix: reload channel state if frozen flag changed (GetStream#1196) chore(release): v8.14.1 (GetStream#1195) Update user reference in channel read data (GetStream#1194) chore(release): v8.14.0 (GetStream#1193) feat: axios upgrade to v1 (GetStream#1192) Revert "fix: queue channel WS events until the channel is initialized" (GetStream#1189) chore(release): v8.13.1 (GetStream#1188) fix: undefined values in query params (GetStream#1187) chore(release): v8.13.0 (GetStream#1186) feat: support for SNS (GetStream#1185) chore: release v8.12.4 (GetStream#1184) fix: evaluate channel.lastRead when channel is not initialized (GetStream#1183) chore(release): v8.12.3 (GetStream#1182) fix: queue channel WS events until the channel is initialized (GetStream#1179) chore: release v8.12.2 (GetStream#1181) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Currently
channel.lastRead()throws an error if a channel is uninitialized. Call tochannel.countUnreadMentions()would throw an error in such case too. This complicates the work in an UI with uninitializedChannelinstance which is a valid use-case. This PR proposes to return valid values like 0 for unread mentions count andnullfor last read data and not to break the UI.