Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not store channelData in thread state #1337

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

myandrienko
Copy link
Contributor

@myandrienko myandrienko commented Aug 14, 2024

Cleaning up types a bit:

  1. State when Thread is initialized without an underlying Channel is not very useful. Now threads always have a channel.
  2. Storing channelData separately is excessive, we have it in channel.
  3. staggeredRead removed for now, it's supposed to make a triumphant return at some point.

This will break ThreadProvider in React SDK, fixed in a follow-up PR.

Copy link
Contributor

Size Change: -787 B (-0.18%)

Total Size: 425 kB

Filename Size Change
dist/browser.es.js 92.5 kB -168 B (-0.18%)
dist/browser.full-bundle.min.js 52.7 kB -83 B (-0.16%)
dist/browser.js 93.6 kB -180 B (-0.19%)
dist/index.es.js 92.6 kB -171 B (-0.18%)
dist/index.js 93.7 kB -185 B (-0.2%)

compressed-size-action

@myandrienko myandrienko merged commit a08ffb1 into feat/threads-v2 Aug 14, 2024
1 of 6 checks passed
@myandrienko myandrienko deleted the feat/threads-v2-no-channel-data branch August 14, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants