Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Thread): parentMessage delete & initial read object #1366

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

arnautov-anton
Copy link
Contributor

@arnautov-anton arnautov-anton commented Sep 16, 2024

This PR solves three issues:

  • adds handler for the reaction.updated event
  • adds handler for deletion of the parent message (and itself)
  • adds "patchy" placeholder read object with current user from which the unreadMessageCount can be incremented on message.new

Noteworthy changes:

  • generateThread function has been renamed to generateThreadResponse
  • updateParentMessageLocally takes object with message property to align with the rest of the methods
  • channel "re-establishing" has been removed from the updateParentMessageLocally method, the channel has its own competences and should update its own data during applicable events

Copy link
Contributor

Size Change: +396 B (+0.09%)

Total Size: 427 kB

Filename Size Change
dist/browser.es.js 92.6 kB +83 B (+0.09%)
dist/browser.full-bundle.min.js 54.1 kB +32 B (+0.06%)
dist/browser.js 93.8 kB +99 B (+0.11%)
dist/index.es.js 92.7 kB +84 B (+0.09%)
dist/index.js 93.8 kB +98 B (+0.1%)

compressed-size-action

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool !

@arnautov-anton arnautov-anton merged commit 3f29e32 into master Sep 17, 2024
6 checks passed
@arnautov-anton arnautov-anton deleted the fix/thread-related-patches branch September 17, 2024 09:25
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants