Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHAT-790] support filter by custom data in search endpoint #264

Merged
merged 10 commits into from
Mar 9, 2020

Conversation

thesyncim
Copy link
Member

@thesyncim thesyncim commented Feb 26, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@thesyncim thesyncim changed the title support filter by custom data in search endpoint [CHAT-790] support filter by custom data in search endpoint Feb 26, 2020
@@ -128,6 +128,28 @@ export class Channel {
});
}

async search(query, options = {}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some doc and examples of what query looks like?

...options,
};
if (typeof query === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some doc for this search function as well!!

Copy link
Contributor

@bogdan-getstream bogdan-getstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thesyncim thesyncim merged commit 1990fdf into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the CHAT-790-m-search branch March 9, 2020 13:11
kevinnath1007 pushed a commit to kevinnath1007/stream-chat-js that referenced this pull request Aug 31, 2022
fix: fix location renderer in localcommunity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants