Updating countUnread function #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.05 kB (0%) Total Size: 196 kB
|
vishalnarkhede
force-pushed
the
vishal/unread-count-fix
branch
from
3bdafbf
to
0f5ed75
Compare
vishalnarkhede
changed the title
vishalnarkhede
commented
Oct 1, 2020
| @@ -1097,16 +1097,17 @@ export class Channel< | |||
| } | |||
|
|
|||
| /** | |||
| * countUnread - Count the number of messages with a date thats newer than the last read timestamp | |||
| * countUnread - Count of unread messages | |||
| * | |||
| * @param {Date | Immutable.ImmutableDate | null} [lastRead] lastRead the time that the user read a message, defaults to current user's read state | |||
| * | |||
| * @return {number} Unread count | |||
| */ | |||
| countUnread(lastRead?: Date | Immutable.ImmutableDate | null) { | |||
There was a problem hiding this comment.
countUnread function fails to return actual count of unread messages if [number of unread messages] > [number of messages loaded/queried in channel]. E.g., if user queries only first page of channel messages and user has 100 unread messages ---> channel.countUnread() will return only 25.
vishalnarkhede
commented
Oct 1, 2020
| @@ -1462,6 +1464,10 @@ export class Channel< | |||
| event.user.id, | |||
| Immutable({ user: { ...event.user }, last_read: event.received_at }), | |||
| ); | |||
|
|
|||
| if (event.user?.id === this.getClient().user?.id) { | |||
| s.unreadCount = 0; | |||
There was a problem hiding this comment.
set to 0 message.read event.
DanC5
approved these changes
Oct 1, 2020
mahboubii
reviewed
Oct 5, 2020
vishalnarkhede
commented
Oct 6, 2020
mahboubii
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #336