[CHAT-1471] Allowed/blocked file extensions and content types #582
Conversation
|
Size Change: 0 B Total Size: 214 kB ℹ️ View Unchanged
|
src/types.ts
Outdated
| @@ -1251,12 +1253,24 @@ export type AppSettings = { | |||
| disable_auth_checks?: boolean; | |||
| disable_permissions_checks?: boolean; | |||
| enforce_unique_usernames?: 'no' | 'app' | 'team'; | |||
| file_upload_config?: { | |||
| allowed_file_extensions?: string[]; | |||
| allowed_mime_types?: string[]; | |||
There was a problem hiding this comment.
Just to confirm, do we have some exhaustive list of all these types/extensions? @miagilepner
There was a problem hiding this comment.
We don't. We could make an exhaustive list (e.g. for the media types the full list is here: https://www.iana.org/assignments/media-types/media-types.xhtml) and do validation, if you think this should be prioritized.
There was a problem hiding this comment.
Not necessary tbh. If backend is prepared to handle any wierd type ... then its totally fine!!
There was a problem hiding this comment.
let's put a comment in here with the link to the accepted types
Co-authored-by: Vishal Narkhede <vishalnarkhede.iitd@gmail.com>
| @@ -1460,6 +1475,13 @@ export type Field = { | |||
| value?: string; | |||
| }; | |||
|
|
|||
| export type FileUploadConfig = { | |||
There was a problem hiding this comment.
why don't we use this type above ?
There was a problem hiding this comment.
was following the way that it's done for other objects, which repeat fields rather than using the type.
There was a problem hiding this comment.
any example for a reference ?
There was a problem hiding this comment.
Ah, you're right. I thought firebase_config and apn_config did this, but I see now they have slightly different fields in AppSettings. I'll fix that.
There was a problem hiding this comment.
Yes, they are different slightly but here is exactly same. Thanks for updating.
delete-merged-branch
bot
deleted the
feat/CHAT-1471-app-config-upload-types
branch
Submit a pull request
CLA
Description of the pull request