[CHAT-1565] Sync own_reactions in events

[AnatolyRugalev]

This PR fixes the issue of synchronizing own_reactions in incoming events.

The original problem comes from the fact that own_reactions field is not populated for each individual client when broadcasting the event. But fortunately, we already sync this data in the channel state, so replacing related fields in the event object seems like a reasonable solution.

[github-actions]

Size Change: -2.08 kB (0%)

Total Size: 212 kB

Filename	Size	Change
dist/browser.es.js	45.9 kB	-440 B (0%)
dist/browser.full-bundle.min.js	27 kB	-295 B (1%)
dist/browser.js	46.4 kB	-454 B (0%)
dist/index.es.js	45.9 kB	-438 B (0%)
dist/index.js	46.5 kB	-450 B (0%)

_{compressed-size-action}

[vishalnarkhede]

@AnatolyRugalev So the change looks fine to me. I have a suggestion:

With current implementation we mutate the event object inside channelState class. And thats a little confusing. If we override the event object, I think it should be done in channel.ts, where we handle the event. So something like following:

_handleChannelEvent(event) {
  ...
  case 'reaction.new':
    if (event.reaction) {
      /**
       * richReactionsData = {
       *  latest_reactions: {},
       *  own_reactions: {},
       *  reactions_count: {}
       * }
       */
      const richReactionsData = s.addReaction(event.reaction, event.message);
      event.message = { ...event.message, ...richReactionsData};
    }
}

This is assuming we are shipping it with #602

@mahboubii what do you think?

[AnatolyRugalev]

@vishalnarkhede I was trying to do this by returning entire message from addReaction and removeReaction methods, but it turned out challenging with all this immutable stuff. Let's wait for #602 to merge and I will get back to addressing this point as you suggested 👍

[virdesai]

@AnatolyRugalev heads up that #602 was just merged into master

[AnatolyRugalev]

I am still working on this. More improvements are coming:

• correct reaction_counts sync
• on enforce_unique counters could go out of sync if we have more than 1 reaction from this user
• some reactions sync code improvements

[AnatolyRugalev]

After some experimenting I came to the conclusion that we don't need to sync latest_reactions, reaction_counters and reaction_scores manually. It was tempting to do, but in some edge cases this just wouldn't work properly (e.g. reaction.updated event for a reaction that is not loaded to latest_reactions).

Incoming events contain this fields, so we simply update the message with them in the state. own_reactions field though needs to be synchronized manually because of the reasons given above.

[vishalnarkhede]

I will review this tomorrow :)

[ferhatelmas]

LGTM

A bit harder to follow the call but dropped a lot of repetition, I think it's a great improvement in code quality.

[ferhatelmas]

@AnatolyRugalev might want to update PR title since only own_reactions are synced.