Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHAT-2191] async batch delete users #762

Merged
merged 26 commits into from
Oct 28, 2021
Merged

[CHAT-2191] async batch delete users #762

merged 26 commits into from
Oct 28, 2021

Conversation

gumuz
Copy link
Contributor

@gumuz gumuz commented Aug 25, 2021

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2021 •
edited
Loading

Size Change: +1.41 kB (0%)

Total Size: 254 kB

Filename Size Change
dist/browser.es.js 55.6 kB +310 B (0%)
dist/browser.full-bundle.min.js 30.3 kB +154 B (0%)
dist/browser.js 56.3 kB +320 B (0%)
dist/index.es.js 55.7 kB +307 B (0%)
dist/index.js 56.3 kB +317 B (0%)

compressed-size-action

yaziine
yaziine reviewed Aug 25, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
mahboubii
mahboubii reviewed Oct 4, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@gumuz
Update src/client.ts
232a965 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
mahboubii
mahboubii reviewed Oct 4, 2021
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@gumuz
Update src/types.ts
6e1d656 
Co-authored-by: Guyon Morée <guyon.moree@gmail.com>
mahboubii
mahboubii reviewed Oct 4, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
@gumuz gumuz requested a review from vicnicius as a code owner October 19, 2021 09:12
vicnicius
vicnicius reviewed Oct 19, 2021
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
vicnicius
vicnicius reviewed Oct 19, 2021
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@gumuz gumuz requested a review from mahboubii October 22, 2021 11:54
mahboubii
mahboubii reviewed Oct 22, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas self-requested a review October 28, 2021 09:35
mahboubii
mahboubii approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@mahboubii mahboubii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas merged commit 4e46077 into master Oct 28, 2021
@ferhatelmas ferhatelmas deleted the async-delete-users branch October 28, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaziine yaziine yaziine left review comments

@mahboubii mahboubii mahboubii approved these changes

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@vicnicius vicnicius vicnicius approved these changes

@AnatolyRugalev AnatolyRugalev Awaiting requested review from AnatolyRugalev

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gumuz @ferhatelmas @vicnicius @yaziine @mahboubii