Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHAT-2049] Add async user export endpoint support #860

Merged
merged 2 commits into from
Jan 13, 2022
Merged

[CHAT-2049] Add async user export endpoint support #860

merged 2 commits into from
Jan 13, 2022

Conversation

SiddhantAgarwal
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Size Change: +95 B (0%)

Total Size: 282 kB

Filename Size Change
dist/browser.es.js 61.5 kB +22 B (0%)
dist/browser.full-bundle.min.js 34.2 kB +13 B (0%)
dist/browser.js 62.2 kB +18 B (0%)
dist/index.es.js 61.6 kB +22 B (0%)
dist/index.js 62.2 kB +20 B (0%)

compressed-size-action

@SiddhantAgarwal SiddhantAgarwal changed the title Add async user export endpoint support [CHAT-2049] Add async user export endpoint support Jan 6, 2022
@AnatolyRugalev AnatolyRugalev marked this pull request as ready for review January 13, 2022 12:34
mahboubii
mahboubii reviewed Jan 13, 2022
View reviewed changes
src/types.ts
@@ -353,6 +353,10 @@ export type ExportChannelResponse = {
task_id: string;
};

export type ExportUsersResponse = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a difference or will be in future between this and ExportChannelResponse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no difference, but wanted to keep it separate just in case we decide to diverge in the future.

@SiddhantAgarwal SiddhantAgarwal merged commit a454d2b into master Jan 13, 2022
@SiddhantAgarwal SiddhantAgarwal deleted the async-export-users branch January 13, 2022 13:24
This was referenced Jan 20, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahboubii mahboubii mahboubii left review comments

@gumuz gumuz gumuz approved these changes

@AnatolyRugalev AnatolyRugalev AnatolyRugalev approved these changes

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SiddhantAgarwal @gumuz @AnatolyRugalev @mahboubii