Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CJS-13] Fix flickering and out-of-order events on truncate.channel with system message #870

Merged
merged 2 commits into from
Jan 19, 2022
Merged

[CJS-13] Fix flickering and out-of-order events on truncate.channel with system message #870

merged 2 commits into from
Jan 19, 2022

Conversation

thesyncim
Copy link
Member

@thesyncim thesyncim commented Jan 19, 2022 •
edited
Loading

Changelog

  • Fix flickering and out-of-order events on truncate.channel with system message

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2022 •
edited
Loading

Size Change: +121 B (0%)

Total Size: 282 kB

Filename Size Change
dist/browser.es.js 61.5 kB +26 B (0%)
dist/browser.full-bundle.min.js 34.2 kB +7 B (0%)
dist/browser.js 62.2 kB +31 B (0%)
dist/index.es.js 61.6 kB +28 B (0%)
dist/index.js 62.3 kB +29 B (0%)

compressed-size-action

@thesyncim thesyncim changed the title CJS-13 Fix flickering and out-of-order events on truncate.channel CJS-13 Fix flickering and out-of-order events on truncate.channel with system message Jan 19, 2022
@thesyncim thesyncim marked this pull request as ready for review January 19, 2022 15:01
@thesyncim thesyncim changed the title CJS-13 Fix flickering and out-of-order events on truncate.channel with system message [CJS-13] Fix flickering and out-of-order events on truncate.channel with system message Jan 19, 2022
AnatolyRugalev
AnatolyRugalev previously approved these changes Jan 19, 2022
View reviewed changes
ferhatelmas
ferhatelmas approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thesyncim thesyncim enabled auto-merge (squash) January 19, 2022 15:31
@thesyncim thesyncim merged commit f1552ab into master Jan 19, 2022
@thesyncim thesyncim deleted the handle-out-of-order-events-in-truncate-channel branch January 19, 2022 15:32
ferhatelmas pushed a commit that referenced this pull request Jan 19, 2022
@thesyncim @ferhatelmas
[CJS-13] Fix flickering and out-of-order events on truncate.channel w…
07c161e 
…ith system message (#870)

* add message present in truncate channel events

* remove else branch for pinned messages
This was referenced Jan 20, 2022
Closed
Merged
ffenix113 pushed a commit that referenced this pull request Jan 20, 2022
@thesyncim @ffenix113
[CJS-13] Fix flickering and out-of-order events on truncate.channel w…
2a57440 
…ith system message (#870)

* add message present in truncate channel events

* remove else branch for pinned messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@AnatolyRugalev AnatolyRugalev AnatolyRugalev approved these changes

@gumuz gumuz Awaiting requested review from gumuz

@mahboubii mahboubii Awaiting requested review from mahboubii

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@petyosi petyosi Awaiting requested review from petyosi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesyncim @ferhatelmas @AnatolyRugalev