Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1104] Fix message list dismissing in modal when scrolling #1364

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Aug 11, 2021

Description of the pull request

Problem:

Currently, we are using an inverted UITableView for the message list. This causes an issue when the message list is presented in a modal because when the tableview is reaching the bottom, the modal actually thinks it is reaching the top and starts dismissing the modal.

More details here: #1307

Solution:

In order to fix this, the most simple workaround, for now, is to disable the dismissing of the modal when the table view is scrolling. The con with this workaround is that the user can't dismiss the modal while scrolling to the top. The user needs to dismiss the modal from the navigation bar or other place. Please watch the example below:

Screen.Recording.2021-08-11.at.21.53.33.mp4

@nuno-vieira nuno-vieira added the 🐞 Bug An issue or PR related to a bug label Aug 11, 2021
@nuno-vieira nuno-vieira requested a review from b-onc August 11, 2021 20:57
@codecov-commenter
Copy link

Codecov Report

Merging #1364 (f035eb9) into main (8a4e196) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1364   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         224      224           
  Lines        9809     9809           
=======================================
  Hits         8901     8901           
  Misses        908      908           
Flag Coverage Δ
llc-tests 90.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4e196...f035eb9. Read the comment docs.

b-onc
b-onc previously approved these changes Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants