Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ListChangeAggregator newIndexPath on Updates #2076

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jun 8, 2022

🔗 Issue Links

None

🎯 Goal

Switching the ListChangeAggregator to the newIndexPath caused multiple crashes. In Apple documentation, they use the oldIndexPath, so this PR reverts that change and also stops checking for conflicts between Inserts and Updates to avoid unnecessary reload data.

📝 Summary

  • Reverts the ListChangeAggregator Update IndexPath. Switches back to the oldIndexPath.
  • Don't treat Insert<->Updates has conflicts in ListChangeIndexPathResolver

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Jun 8, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner June 8, 2022 18:31
@nuno-vieira nuno-vieira force-pushed the fix/use-old-indexPath-in-change-aggregator branch 3 times, most recently from 1a012c9 to cecc1c3 Compare June 8, 2022 20:13
@nuno-vieira nuno-vieira force-pushed the fix/use-old-indexPath-in-change-aggregator branch from cecc1c3 to ed2aa81 Compare June 8, 2022 20:16
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira merged commit f80cbbe into release/4.16.0 Jun 9, 2022
@nuno-vieira nuno-vieira deleted the fix/use-old-indexPath-in-change-aggregator branch June 9, 2022 10:13
@nuno-vieira nuno-vieira mentioned this pull request Jun 9, 2022
@bielikb bielikb mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants