-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert ListChangeAggregator newIndexPath on Updates #2076
Merged
nuno-vieira
merged 7 commits into
release/4.16.0
from
fix/use-old-indexPath-in-change-aggregator
Jun 9, 2022
Merged
Revert ListChangeAggregator newIndexPath on Updates #2076
nuno-vieira
merged 7 commits into
release/4.16.0
from
fix/use-old-indexPath-in-change-aggregator
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
An issue or PR related to a bug
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
labels
Jun 8, 2022
evsaev
reviewed
Jun 8, 2022
evsaev
reviewed
Jun 8, 2022
Sources/StreamChatUI/Utils/ListChangeUpdater/ListChangeIndexPathResolver.swift
Outdated
Show resolved
Hide resolved
evsaev
reviewed
Jun 8, 2022
Sources/StreamChatUI/Utils/ListChangeUpdater/TableViewListChangeUpdater.swift
Show resolved
Hide resolved
nuno-vieira
force-pushed
the
fix/use-old-indexPath-in-change-aggregator
branch
3 times, most recently
from
June 8, 2022 20:13
1a012c9
to
cecc1c3
Compare
nuno-vieira
force-pushed
the
fix/use-old-indexPath-in-change-aggregator
branch
from
June 8, 2022 20:16
cecc1c3
to
ed2aa81
Compare
evsaev
reviewed
Jun 8, 2022
Sources/StreamChatUI/Utils/ListChangeUpdater/ListChangeIndexPathResolver.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
evsaev
approved these changes
Jun 9, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
None
🎯 Goal
Switching the
ListChangeAggregator
to thenewIndexPath
caused multiple crashes. In Apple documentation, they use theoldIndexPath
, so this PR reverts that change and also stops checking for conflicts between Inserts and Updates to avoid unnecessary reload data.📝 Summary
ListChangeIndexPathResolver
☑️ Contributor Checklist