Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Action title now supports 2 lines of text instead of 1 #2082

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Message Action title now supports 2 lines of text instead of 1 #2082

merged 2 commits into from
Jun 10, 2022

Conversation

bielikb
Copy link
Contributor

@bielikb bielikb commented Jun 10, 2022 •
edited
Loading

🎯 Goal

Do not truncate the title of message action in message actions pop up.

🛠 Implementation

  • titleLabel now supports showing 2 lines of text instead of 1
  • fixes indentation of the pop up

🎨 Showcase

Before After
Simulator Screen Shot - iPod touch (7th generation) - 2022-06-10 at 12 48 58 Simulator Screen Shot - iPod touch (7th generation) - 2022-06-10 at 12 47 57

🧪 Manual Testing Notes

  1. Use title that takes 2lines of text for one of the support message actions
  2. Run the app.
  3. Invoke the message action pop up and verify it works fine.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@bielikb bielikb requested a review from a team as a code owner June 10, 2022 11:02
@bielikb bielikb changed the title Message Action is now limit to 2 lines of text instead of 1 Message Action title now supports 2 lines of text instead of 1 Jun 10, 2022
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jun 10, 2022 •
edited
Loading

1 Error
🚫 Please start subject with capital letter.
dbf1c47

Generated by 🚫 Danger

evsaev
evsaev approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@evsaev evsaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the changelog 👍

@bielikb
Copy link
Contributor Author

bielikb commented Jun 10, 2022

LGTM but the changelog 👍

@evsaev Im waiting for the merge from main to avoid any unnecessary conflicts :)

@bielikb bielikb added 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK 🐞 Bug An issue or PR related to a bug labels Jun 10, 2022
@bielikb bielikb force-pushed the bugfix/context_menu_item_2lines branch from 0050c8f to dbf1c47 Compare June 10, 2022 11:30
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bielikb bielikb merged commit fd1df6d into develop Jun 10, 2022
@bielikb bielikb deleted the bugfix/context_menu_item_2lines branch June 10, 2022 12:09
@adolfogarza adolfogarza mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evsaev evsaev evsaev approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bielikb @Stream-SDK-Bot @evsaev