-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1900] Push Notifications - multi bundle support #2101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we just have another configuration
(e.g. alpha
) instead of 2nd target? Because that's the approach enterprise usually follows: they ship 1 app version for internal testing purposes via TestFlight and another app is a production app available in AppStore for end users. They have single target but multiple configurations which bundle identifier depends on
Usually you have separate targets per each type of app (staging, production). The separation of concerns via another app target for multi bundle app makes it easy to configure the build settings/phases the way they make sense for you. eg adding support for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
🔗 Issue Links
CIS-1900
🎯 Goal
Allow integrator to leverage multi-bundle feature via exposing new parameter to
addDevice
API calledprovider name
.Provider name represents the name of the push configuration created in Stream dashboard.
Push configurations are located under
Push Notifications
tab in the dashboard.Multi-bundle support allows the integrator to list multiple client apps under one Stream app in the dashboard. (eg. when leveraging
Staging
vs.Production
setup).The default configuration will be used if no
provider name
is specified.Available API:
APN:
Firebase:
📝 Changes
New optional
providerName
parameter can be specified for bothapn
andfirebase
integrations.Existing
provider
parameter in thePushDevice
struct was renamed topushProvider
to gain API alignment with Android.In order to have a way to test the to multi-bundle support, new
DemoApp
target was added to the integration apps repo with bundle identifierio.getstream.iOS.ChatDemoAppTwo
.Additionally, a new Info section was added to our
DemoApp
to clarify which push configuration is used by our default develop app.client
property insideStreamChatWrapper
is no longer forced-cast.Important Note 📜
Docs will be added in separate PR, this PR contains only the implementation part.
🧪 Manual Testing Notes
multi-bundle
branch in integration apps repoLuke
from a different app/web☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)