[CIS-1591] Fix message list scrolling when popping from navigation stack #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
|
Kudos, SonarCloud Quality Gate passed!
|
nuno-vieira
deleted the
fix/CIS-1591-Fix-message-list-scrolling-when-swiping-back
branch
Merged
polqf
pushed a commit
that referenced
this pull request
Sep 1, 2022
…ack (#2239) * Fix message list scrolling when popping from navigation stack * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
CIS-1591
#1793
🎯 Goal
Fix the message list scrolling when popping the message list from the navigation stack.
🛠 Implementation
The reason this happened was that the Keyboard hide notification is still triggered when popping from the navigation stack, and the keyboard is dismissed but there's no animation, only the message list animates. To fix this, on the keyboard handler we check if the view controller is still present in the navigation stack. If not, we don't hide the keyboard.
🎨 Showcase
RPReplay_Final1660739284.mov
video.mp4
🧪 Manual Testing Notes
☑️ Contributor Checklist