Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS-1771] Expose method for clearing local DB data #2241

Merged
merged 6 commits into from
Aug 23, 2022
Merged

[CIS-1771] Expose method for clearing local DB data #2241

merged 6 commits into from
Aug 23, 2022

Conversation

hugobernalstream
Copy link
Contributor

@hugobernalstream hugobernalstream commented Aug 17, 2022 •
edited
Loading

Add logout method for properly disconnecting users and clearing local…… data.

🔗 Issue Links

CIS-1771

🎯 Goal

Provide a way to properly logout the users by disconnecting them form the service (as currently done) and clearing the related stored local data.

🛠 Implementation

  • Disconnect and remove all data from the databaseContainer when calling logout.

🎨 Showcase

logout - data cleared and reloaded

Files being updated after removing stores and being refreshed.

🧪 Manual Testing Notes

Implemented on the DemoApp so can be tested when logging out the user.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@hugobernalstream hugobernalstream added the 🔧 WIP A PR that is Work in Progress label Aug 17, 2022
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 18, 2022 •
edited
Loading

2 Errors
🚫 Please remove period from end of commit subject line.
32551f4
🚫 Please remove period from end of commit subject line.
e5af9f3

Generated by 🚫 Danger

@hugobernalstream hugobernalstream changed the title [Draft][CIS-1771] Expose method for clearing local DB data [CIS-1771] Expose method for clearing local DB data Aug 19, 2022
@hugobernalstream hugobernalstream removed the 🔧 WIP A PR that is Work in Progress label Aug 19, 2022
@hugobernalstream hugobernalstream marked this pull request as ready for review August 19, 2022 17:38
@hugobernalstream hugobernalstream requested a review from a team as a code owner August 19, 2022 17:38
nuno-vieira
nuno-vieira reviewed Aug 22, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@hugobernalstream @nuno-vieira
Update docusaurus/docs/iOS/uikit/getting-started.md
9764fce 
Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
nuno-vieira
nuno-vieira approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@hugobernalstream hugobernalstream merged commit 86daace into develop Aug 23, 2022
@hugobernalstream hugobernalstream deleted the feature/CIS-1771-Logout_and_clear_DB branch August 23, 2022 17:48
@polqf polqf mentioned this pull request Sep 1, 2022
Merged
polqf pushed a commit that referenced this pull request Sep 1, 2022
@hugobernalstream @nuno-vieira @polqf
[CIS-1771] Expose method for clearing local DB data (#2241)
df38c90 
* Add logout method for properly disconnecting users and clearing local data.

* Update documentation on logout, remove completion from logout and add test.

* Update change log

* Code review fixes

* Update docusaurus/docs/iOS/uikit/getting-started.md

Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>

Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
@nuno-vieira nuno-vieira mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf left review comments

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugobernalstream @Stream-SDK-Bot @polqf @nuno-vieira