-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing member
field in notification.removed_from_channel
event
#2259
Fix parsing member
field in notification.removed_from_channel
event
#2259
Conversation
notification.removed_from_channel
eventmember
field in notification.removed_from_channel
event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only comment I would add is that we should be using optionals instead of unwrapped values in tests
@polqf That will take some time to change. Besides that, most of the tests are performing against optional values, so if we just use the optional value on the actuals, there's a chance of having false positives, if both are nil |
…nt (#2259) * Fix parsing the member in "notification.removed_from_channel" event * Add test coverage * Update CHANGELOG.md
🔗 Issue Links
#2251
🎯 Goal
In the
notification.removed_from_channel
event, theuser
field is not present inside themember
field, although theuser_id
is. This PR adds a fallback so that if theuser
is not present, we use the id from theuser_id
property.The backend will change this meanwhile, and make sure the
user
field is always present. But since we don't have an ETA for this, it makes sense to add this fallback.☑️ Contributor Checklist