Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS-1583] Fix Thread not loading more replies #2297

Merged
merged 6 commits into from
Sep 16, 2022
Merged

[CIS-1583] Fix Thread not loading more replies #2297

merged 6 commits into from
Sep 16, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Sep 15, 2022 •
edited
Loading

🔗 Issue Links

CIS-1583

🎯 Goal

Fix not loading more replies in Threads

📝 Summary

  • Fixes threads not loading more replies because of the controller state not being remote fetched (which is not needed)
  • Fixes threads and channels not loading more messages when initialized offline

🎨 Showcase

None

🧪 Manual Testing Notes

  • Open a Channel Thread with multiple replies
  • Scroll to the top
  • Should load more messages

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK 🤞 Ready For QA A PR that is Ready for QA labels Sep 15, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner September 15, 2022 12:34
@nuno-vieira nuno-vieira force-pushed the fix/CIS-1583-Thread-pagination-not-loading-more-replies branch from 65f0dc4 to a2719d4 Compare September 15, 2022 12:36
@nuno-vieira nuno-vieira removed the 🤞 Ready For QA A PR that is Ready for QA label Sep 15, 2022
@nuno-vieira nuno-vieira changed the title [CIS-1583] Fix Thread pagination not loading more replies [CIS-1583] Fix Thread not loading more replies Sep 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira added the 🤞 Ready For QA A PR that is Ready for QA label Sep 15, 2022
@Stream-SDK-Bot
Copy link
Collaborator

1 Warning
⚠️ The changes should be manually QAed before the Pull Request will be merged

Generated by 🚫 Danger

@testableapple testableapple added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels Sep 16, 2022
@testableapple
Copy link
Contributor

🥁 ... LGTM 🙂

@nuno-vieira nuno-vieira merged commit 2d67fad into develop Sep 16, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-1583-Thread-pagination-not-loading-more-replies branch September 16, 2022 16:35
@nuno-vieira nuno-vieira mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuno-vieira @Stream-SDK-Bot @testableapple @polqf