[CIS-2184] Ignore channel.created events #2314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://stream-io.atlassian.net/browse/CIS-2184
🎯 Goal
Stop logging error when 'channel.created' events are received
📝 Summary
We are already handling new channels when ‘notification.added_to_channel' are received.
’channel.created' events are only received through the sync endpoint, but we were logging an error as it was unhandled, but it seemed like there was a bug.
🛠 Implementation
When receiving 'channel.created', we are throwing
ClientError.UnsupportedEventType
, which is then only logged as info🧪 Manual Testing Notes
Expected result:
No error logs regarding 'channel.created' should appear
Previous result:
An error log would be logged for 'channel.created'
☑️ Contributor Checklist
🎁 Meme