Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-2184] Ignore channel.created events #2314

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

polqf
Copy link
Contributor

@polqf polqf commented Sep 22, 2022

🔗 Issue Links

https://stream-io.atlassian.net/browse/CIS-2184

🎯 Goal

Stop logging error when 'channel.created' events are received

📝 Summary

We are already handling new channels when ‘notification.added_to_channel' are received.
’channel.created' events are only received through the sync endpoint, but we were logging an error as it was unhandled, but it seemed like there was a bug.

🛠 Implementation

When receiving 'channel.created', we are throwing ClientError.UnsupportedEventType, which is then only logged as info

🧪 Manual Testing Notes

  1. Logged with user A, and the app closed
  2. With user B, create a group including user A
  3. Open the app with user A

Expected result:
No error logs regarding 'channel.created' should appear

Previous result:
An error log would be logged for 'channel.created'

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

@polqf polqf requested a review from a team as a code owner September 22, 2022 13:59
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@polqf polqf merged commit 3522327 into develop Sep 26, 2022
@polqf polqf deleted the bugfix/ignore-channel-created-event branch September 26, 2022 10:33
@nuno-vieira nuno-vieira mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants