Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS-2287] Fix connecting user with non-expiring tokens #2393

Merged
merged 3 commits into from
Nov 30, 2022
Merged

[CIS-2287] Fix connecting user with non-expiring tokens #2393

merged 3 commits into from
Nov 30, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Nov 30, 2022 •
edited
Loading

🔗 Issue Links

#2382
CIS-2287

🎯 Goal

Fix development tokens not working, it errors with Missing Token Provider.

🛠 Implementation

When creating a development token, we were incorrectly setting the expiration to "distantFuture". We actually need to set it to nil. Since there is no expiration at all. With this, the connectUser now works correctly.

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Nov 30, 2022
@nuno-vieira nuno-vieira marked this pull request as ready for review November 30, 2022 14:21
@nuno-vieira nuno-vieira requested a review from a team as a code owner November 30, 2022 14:21
@nuno-vieira nuno-vieira force-pushed the fix/CIS-2287-Development-tokens-error-with-missing-token-provider branch from 66f8c7d to c4db2f6 Compare November 30, 2022 14:22
@nuno-vieira nuno-vieira changed the title [CIS-2287] Fix connecting user without expiration tokens [CIS-2287] Fix connecting user wit no-expiration tokens Nov 30, 2022
@nuno-vieira nuno-vieira changed the title [CIS-2287] Fix connecting user wit no-expiration tokens [CIS-2287] Fix connecting user with non-expiring tokens Nov 30, 2022
@nuno-vieira nuno-vieira force-pushed the fix/CIS-2287-Development-tokens-error-with-missing-token-provider branch from c4db2f6 to 07aa327 Compare November 30, 2022 14:25
@nuno-vieira nuno-vieira mentioned this pull request Nov 30, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira merged commit 546d764 into develop Nov 30, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-2287-Development-tokens-error-with-missing-token-provider branch November 30, 2022 16:47
@polqf polqf mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuno-vieira @polqf