Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-2024, CIS-2000] Fix Channel List pagination gaps + Truncated channels moved to bottom #2420

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Dec 15, 2022

🔗 Issue Links

CIS-2024
CIS-2000
#2358

🎯 Goal

  • Fix channel list pagination gaps by introducing fetchLimit and fetchBatchSize in the channel list fetch request.
  • Fix truncated channels being moved to the bottom of the channel list because of the wrong lastMessageAt value being used in defaultSortingAt.

🧪 Manual Testing Notes

Truncation fix:

  • Open a channel
  • Truncate the top channel
  • It should not be moved to the bottom

Pagination fix:

  • Load multiple channels (Keep scrolling to the bottom)
  • Restart the app
  • The channel list should only contain the first 20 channels, and not all channels which are in the local cache
  • When loading more channels, it should keeping loading 20 by 20

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Dec 15, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner December 15, 2022 18:54
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira merged commit c29227c into develop Dec 19, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-2024-2000-Fix-channel-list-pagination-gaps branch December 19, 2022 10:10
@polqf polqf mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants