-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable deleting messages in pendingSend state #2432
Conversation
Generated by 🚫 Danger |
📏 Size AnalysisTotal install size 10.6 MB | This change: ⬆️ +178.8 kB (+1.71%)🗂 See size breakdown
🔎 See the full size analysis (7dabbba) merging into develop (5d16c7b)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ I think we should only make sure we update the changelog 👍
Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
🔗 Issue Links
GH
Follow-up ticked should be created to improve the experience in the UIKit SDK.
🎯 Goal
We need to be able to delete messages in
pendingSend
state. If a message doesn't change it's state while it's being sent (e.g. kill the app while uploading a video), you can't do any action with it - it just stays inpendingSend
.The goal of the PR is to allow such messages to be deleted.
🛠 Implementation
Updated the logic in the
MessageUpdater
'sdeleteMessage
to allow deleting only local messages when the state ispendingSend
.🎨 Showcase
No visual changes.
🧪 Manual Testing Notes
Open the SwiftUI app. Add a video, and while uploading, kill the app. You should be able to delete this message when you come back (previously it was not possible).
☑️ Contributor Checklist
🎁 Meme