Fix channel.pinnedMessages
with missing messages
#3244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/862
🎯 Goal
Fixes
channel.pinnedMessages
not containing the whole data from the server.🛠 Implementation
The logic was incorrect. We were removing the pinned messages from
channel.pinnedMessages
if they already existed in the array. This is wrong. It should only be removed if they are not pinned anymore.🧪 Manual Testing Notes
Not required. Covered by unit tests.
☑️ Contributor Checklist