Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on background mapping #3250

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

Resolves ios-issues-tracking/issues/863

🎯 Goal

Set background mapping default to true.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus laevandus requested a review from a team as a code owner June 17, 2024 12:44
@Stream-SDK-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 1.67 ms 83.3% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 0.65 ms per s 83.75% 🔼 🟢
Frame rate 79 fps 78.19 fps 1.03% 🔼 🟢
Number of hitches 1 0.2 80.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 18.36 ms -46.88% 🔽 🔴
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 5 ms per s 7.2 ms per s -44.0% 🔽 🔴
Frame rate 76 fps 74.45 fps 2.04% 🔼 🟢
Number of hitches 1.2 2.0 -66.67% 🔽 🔴

@laevandus laevandus marked this pull request as draft June 18, 2024 08:09
@laevandus laevandus marked this pull request as ready for review June 18, 2024 09:58
@laevandus laevandus enabled auto-merge (squash) June 18, 2024 10:01
@Stream-SDK-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 2.6 ms per s 35.0% 🔼 🟢
Frame rate 79 fps 78.19 fps 1.03% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 21.7 ms -73.6% 🔽 🔴
Duration 2.6 s 2.57 s 1.15% 🔼 🟢
Hitch time ratio 5 ms per s 8.46 ms per s -69.2% 🔽 🔴
Frame rate 76 fps 74.15 fps 2.43% 🔼 🟢
Number of hitches 1.2 2.4 -100.0% 🔽 🔴

@laevandus laevandus force-pushed the change/background-mapping-enabled branch from b8ff9ce to fd21ddf Compare June 18, 2024 10:44
CHANGELOG.md Outdated Show resolved Hide resolved
@laevandus laevandus disabled auto-merge June 18, 2024 12:28
@laevandus laevandus force-pushed the change/background-mapping-enabled branch from fd21ddf to 2fcb3ee Compare June 19, 2024 06:53
@laevandus laevandus enabled auto-merge (squash) June 19, 2024 06:53
@laevandus laevandus disabled auto-merge June 19, 2024 09:21
@laevandus
Copy link
Contributor Author

Ran unit-tests and UI-tests locally.

@laevandus laevandus merged commit cdf927b into develop Jun 19, 2024
12 of 14 checks passed
@laevandus laevandus deleted the change/background-mapping-enabled branch June 19, 2024 11:06
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants