Fix the thread name printed by the Logger
#3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The thread name was being read inside `loggerQueue.async{}`, which made it always print
`io.getstream.logconfig`. Fixed to read it before entering the dispatch queue, and now it prints the correct thread name.
SagarSDagdu
force-pushed
the
fix-logger-thread-name
branch
from
a1a6e1b
to
55587ed
Compare
|
Ahah I see you missed us @SagarSDagdu 😛 Thank you for the fix! |
|
Hi @SagarSDagdu, this change has been released with 4.63.0. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Make the logger print the correct thread name
📝 Summary
The thread name was being read inside
loggerQueue.async {}, which made it always printio.getstream.logconfig. Fixed to read it before entering the dispatch queue, and now it prints the correct thread name.☑️ Contributor Checklist
🎁 Meme