Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Filter.notEqual and Filter.notIn #3414

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Deprecate Filter.notEqual and Filter.notIn #3414

merged 1 commit into from
Sep 6, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Sep 6, 2024 •
edited by jira bot
Loading

🔗 Issue Links

Resolves: PBE-5681

🎯 Goal

Deprecate slow filter operators

📝 Summary

Filter.notEqual and Filter.notIn cause performance issues and are considered to be removed in the future.

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus laevandus added the 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Sep 6, 2024
@laevandus laevandus requested a review from a team as a code owner September 6, 2024 12:12
@laevandus laevandus enabled auto-merge (squash) September 6, 2024 12:18
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.83 MB 6.83 MB 0 KB 🟢
StreamChatUI 4.42 MB 4.42 MB 0 KB 🟢

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
159 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.9% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@laevandus laevandus merged commit 681b59f into develop Sep 6, 2024
15 of 16 checks passed
@laevandus laevandus deleted the deprecation/nin branch September 6, 2024 12:55
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laevandus @Stream-SDK-Bot @martinmitrevski