✨ [Feature] Google OAuth login #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .env.development 만 있을 경우를 위해 파일 경로 추가
- strategy 의 auth table 에 접근해서 유저 정보를 확인하는 로직을 auth service 로 변경 - ftGuard 의 에러 체크 loop 삭제 - LoginInfo 타입 변경, SocialResponseOptions 타입 추가 - web socket connect 시점의 console.log 삭제
- 통일성 있는 api 형태로 변경 - 쓰이지 않는 UseGuard 삭제
- google oauth 를 위한 configuration 모듈 생성 - ft configuration callback 변수 이름을 FORTYTWO_CALLBACK_URL 으로 변경
nyeoni
approved these changes
Aug 21, 2023
|
@jis-kim 프론트도 url 변경 완료하였습니다! 확인해주시고 괜찮으시면 바로 머지 부탁드릴게용 >_< 👍 |
nyeoni
added a commit
that referenced
this pull request
Aug 22, 2023
Co-authored-by: nyeoni <skdusdl8804@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
console.log, ft guard check,@UseGuard()데코레이터를 삭제했습니다.Describe your changes
google.strategy.ts,google.guard.ts파일이 추가되었습니다.AuthController에 있던 로그인 후 signup/signin/2fa 구분하는 코드를AuthService로 옮겼습니다./auth/42login->/auth/login/ft,/auth/callback/ft로 변경/auth/42login/2fa->/auth/login/2fa로 변경/auth/login/google,/auth/callback/google추가.env인자 추가 및 변경Issue number and link