Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub out unstable_const feature #84

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Conversation

RalfJung
Copy link
Collaborator

@RalfJung RalfJung commented Mar 26, 2024

It is pointless, nightly users get stable_offset_of which switches out the entire implementation and makes it fully const-compatible without any nightly feature.

However we can avoid breaking the build of people that enable this feature, by simply making it do nothing. If they are on a ~recent nightly (less than 3 months old), they will get stable_offset_of which subsumes all the unstable features. If they are on an older nightly they should stick to older versions of memoffset.

CHANGELOG.md Outdated Show resolved Hide resolved
@RalfJung RalfJung changed the title remove unstable_const feature stub out unstable_const feature Mar 26, 2024
@Gilnaa Gilnaa merged commit 0ec6b3b into Gilnaa:master Mar 26, 2024
13 checks passed
@RalfJung RalfJung deleted the no-nightly branch March 26, 2024 20:29
@RalfJung
Copy link
Collaborator Author

@Gilnaa thanks! Can you do an 0.9.1 release? :)

@RalfJung
Copy link
Collaborator Author

Ah, you're already on it. :D

@Gilnaa
Copy link
Owner

Gilnaa commented Mar 26, 2024

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants