Merge pull request #874 from tlnagy/pull-request/e5ea6fc4

modify bar handling to be more like other geometries

src/geom/bar.jl

@@ -14,16 +14,22 @@ immutable BarGeometry <: Gadfly.GeometryElement
     default_statistic::Gadfly.StatisticElement
 
     tag::Symbol
-end
 
+    function BarGeometry(; position::Symbol=:stack,
+                         orientation::Symbol=:vertical,
+                         tag::Symbol=empty_tag)
+        new(position, orientation, Gadfly.Stat.bar(position=position,
+            orientation = orientation), tag)
+    end
 
-function bar(; position::Symbol=:stack, orientation::Symbol=:vertical,
-             tag::Symbol=empty_tag)
-    return BarGeometry(
-        position, orientation,
-        Gadfly.Stat.bar(position=position, orientation=orientation), tag)
+    function BarGeometry(position::Symbol, orientation::Symbol,
+                         default_statistic::Gadfly.StatisticElement,
+                         tag::Symbol)
+        new(position, orientation, default_statistic, tag)
+    end
 end
 
+const bar = BarGeometry
 
 function histogram(; position=:stack, bincount=nothing,
                    minbincount=3, maxbincount=150,

test/issue871.jl

@@ -0,0 +1,4 @@
+using Gadfly
+
+# check for method ambiguity using Geom.bar, #871
+plot(x=1:10, y=1:10, Geom.bar, Guide.xlabel("foo"), Guide.ylabel("bar"))

test/runtests.jl

@@ -105,7 +105,8 @@ tests = [
     ("auto_enumerate",                        6inch, 3inch),
     ("coord_limits",                          6inch, 6inch),
     ("rug",                                   6inch, 3inch),
-    ("beeswarm",                              6inch, 3inch)
+    ("beeswarm",                              6inch, 3inch),
+    ("issue871",                              6inch, 3inch)
 ]
 
 
@@ -185,5 +186,3 @@ run_tests("output/test.html")
 #@time run_tests("output/test.html")
 #@profile run_tests("output/test.html")
 #Profile.print()
-
-