Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow updating package when installed with OpenUpm #547

Merged
merged 1 commit into from
Jul 30, 2023
Merged

allow updating package when installed with OpenUpm #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/NuGetForUnity/Editor/NugetWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,8 +1310,18 @@ private void HandleListRequest()
upmPackageListRequest.Result.Any(package => package.name == UpmPackageName))
{
// NuGetForUnity is installed as UPM package so we can just re-add it inside the package-manager to get update (see https://docs.unity3d.com/Manual/upm-git.html)
EditorUtility.DisplayProgressBar("NuGetForUnity update ...", "Installing with UPM", 0.1f);
upmPackageAddRequest = Client.Add(UpmPackageGitUrl);
var packageInfo = upmPackageListRequest.Result.First(package => package.name == UpmPackageName);
if (packageInfo.source == PackageSource.Git)
{
EditorUtility.DisplayProgressBar("NuGetForUnity update ...", "Installing with UPM (git url)", 0.1f);
upmPackageAddRequest = Client.Add(UpmPackageGitUrl);
}
else
{
EditorUtility.DisplayProgressBar("NuGetForUnity update ...", "Installing with UPM (OpenUPM)", 0.1f);
upmPackageAddRequest = Client.Add(UpmPackageName);
}

EditorApplication.update += HandleAddRequest;
}
else
Expand Down
Loading