-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for PluginAPI #564 #597
Conversation
I don't like binaries inside GIT, they can get out-of-sync.
So others can create the Plugin either by:
See how Unity allows "expendability" e.g. with the code: |
Bellow is my reasoning for having to include dll. Correct me if I understood something wrong: We encourage installing NugetForUnity as a UPM package. Installing that way would install the contents of Editor folder as source into user's project. That means PluginAPI would be installed as source as well. But I created some plugin that is compiled into a dll and inside that dll it is recorded that it depends on NugetForUnity.PluginAPI.dll but now there is no such dll in the project. Maybe this would work if we can make Unity compile asmdef for PluginAPI before it tries to load the plugin dll but I am not sure that is possible. |
So the goal is to be able to implement the plugin in a external .csproj and not being limited to only implement it inside the same or a different unity project? |
The plugin has to be a dll (compiled from external csproj) so that it can also be loaded from CLI version. |
… and open nuspec editor
…-of-date check to workflow + workflow create package for NugetForUnity.PluginAPI
.github/workflows/main.yml
Outdated
run: git diff --exit-code ./src/NuGetForUnity/Editor/PluginAPI/NuGetForUnity.PluginAPI.dll | ||
|
||
- name: Ensure NuGetForUnity.PluginAPI.xml in GIT is up-to-date (if it fails pleas build the NugetForUnity.PluginAPI.csproj and upload the changed files to git) | ||
run: git diff --exit-code ./src/NuGetForUnity/Editor/PluginAPI/NuGetForUnity.PluginAPI.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intent here? Will it check that each commit has changes in these files? They should only be updated if something in PluginAPI project was changed which should be pretty rare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No they should only check if NuGetForUnity.PluginAPI.dll
is updated if something it the code of the PluginAPI project was changed. It currenlty has the issue that the .dll
contains the version number so it always failes.
…r images used by github actions
96d93f9
to
2a95125
Compare
@JoC0de thank you very much for helping polish this PR 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I am done with my changes 😄
The implementation looks good 👍
I already updated the version number in the source code to 4.0.2
so we can release it after merging.
No description provided.