Restored em.find in the the refresh function #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added a commit
that referenced
this pull request
Mar 12, 2021
qqmyers
pushed a commit
that referenced
this pull request
Nov 16, 2021
merge IQSS develop into mdm develop
landreev
pushed a commit
that referenced
this pull request
Apr 19, 2024
rewrite :CVocConf docs, explain where to find readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for the current sleep of one second before setting the workflow lock. It partially reverts a change by @qqmyers from 2018 in which a call to
em.findwas replaced byem.merge(which is explained by a comment in the function). This turns out to lead to a lot ofOptimisticLockExceptions inlockDataset, probably because the increased amount of time between the fetching ofDatasetand its persistence inlockDataset.Reverting this change for the
lockDataset-scenario decreased the number of failures because ofOptimisticLockExceptionfrom around 170 out of 700 imports to 0. The sleep of 1 second seems to work, too, but has the disadvantage of increased overall import time (ca 27 hours for 100,000 dataset, so significant).